feat(kanban): carry the review handoff summary into the wake turn - #32
Merged
nikitaBarkov merged 1 commit intoAug 17, 2026
Conversation
`completed` already puts the worker's summary inside the synthetic wake turn, so the woken creator sees what was done. `review_requested` did not: the summary rode the passive ping only, and the wake turn said just "handed off for review", forcing the woken reviewer to re-read the board (and losing the PR link the worker had already written). Reuse the same first-line handoff the `completed` branch builds, so the existing `gateway.kanban.wake.handoff` string renders it — no new locale keys, no change to the passive message.
nikitaBarkov
merged commit Aug 17, 2026
4d3165a
into
sync/upstream-2026-08-14
80 of 86 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Puts the worker's handoff summary inside the synthetic wake turn for
review_requested, the waycompletedalready does.The
completedbranch of the gateway kanban notifier copies the run summary intowake_handoff, which is rendered throughgateway.kanban.wake.handoff("Result: …") in the synthetic turn. Thereview_requestedbranch only used the summary for the passive👀 … ready for reviewping, so the wake turn read "Task X handed off for review; the implementation is done" and nothing else — the woken reviewer had to go read the board to learn what was implemented, and the PR link the worker had already written in its handoff was dropped.Follow-up to #31 (which made
review_requestedwake the origin at all). Same first-line/200-char handoff shape ascompleted, so no new locale keys and no change to the passive message.Related Issue
No issue. Observed on a live board: the review wake turn arrived without the worker's summary, unlike the completion wake turn.
Type of Change
Changes Made
gateway/kanban_watchers.py: in thereview_requestedbranch, setwake_handofffrom the event's summary (first line, 200 chars) exactly like thecompletedbranch does.tests/gateway/test_kanban_notifier.py: the review-handoff task now reports a multi-line summary with a PR link, and the wake test asserts that link is inside the wake turn.website/docs/user-guide/features/kanban.md: state that acompletedorreview_requestedsummary rides the wake turn.How to Test
notify+wake, let a worker callkanban_request_review(summary="PR ready: <url>"). The wake turn now containsResult: PR ready: <url>on top of the passive ping.scripts/run_tests.sh tests/gateway/test_kanban_notifier.py tests/hermes_cli/test_kanban_review_lifecycle.py tests/agent/test_i18n.py -q— 3 files, 67 tests, 0 failures.wake_handoffassignment failstest_review_requested_wakes_the_origin_session.Checklist
Code
Documentation & Housekeeping
website/docs/user-guide/features/kanban.mdcli-config.yaml.example— N/A, no new config keysCONTRIBUTING.md/AGENTS.md— N/A, no architecture or workflow change