Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support project in nested folder in project discovery #114

Closed
dotlogix opened this issue Oct 16, 2023 · 15 comments
Closed

Support project in nested folder in project discovery #114

dotlogix opened this issue Oct 16, 2023 · 15 comments

Comments

@dotlogix
Copy link

In godot you can specify a custom path for your solution.
Is it possible to still detect the godot project using some configuration or property in the csproj maybe?

I usually use ..\ as my solution path to seperate the sln from the actual projects I often have additional project references.
So in my case the folder structure would be:
Root
Game.sln
Game/Game.csproj
Game/.godot
Library/Library.csproj

@van800
Copy link
Collaborator

van800 commented Oct 17, 2023 via email

@dotlogix
Copy link
Author

For me it doesn't but a newly created standard project with .sln and .csproj in the same folder works fine

@dotlogix
Copy link
Author

Just tested it again with a new project definetly does not work.

Repo steps:

  • Open Godot 4.2-beta
  • Create a new Project
  • Go to Settings/Dotnet and set the solution path to ../
    (If you don't see this option enable AdvancedSettings at the top left of the window)
  • Go to Project/Tools/C#/Create Solution
  • Open the created sln with Rider + Godot Support

Expected:
The extension detects the Project as a Godot Project and creates the Configurations for you.

Actual:
Nothing happens and no Confgurations are created

@van800
Copy link
Collaborator

van800 commented Oct 17, 2023

@dotlogix What Rider/Godot plugin versions do you use?

@dotlogix
Copy link
Author

dotlogix commented Oct 17, 2023

@van800
JetBrains Rider 2023.2.2
Godot 4.2.beta1
GodotSupport 2023.2.121

So all up 2 date I guess

@van800
Copy link
Collaborator

van800 commented Oct 18, 2023

I can reproduce that first time opening a new project would not recognize it as godot. If I close and open solution again it becomes recognized.
Is it the same for you?

@van800
Copy link
Collaborator

van800 commented Oct 18, 2023

test.zip

@dotlogix
Copy link
Author

With the current version of the plugin it dosn't work for me with your test project either.
Do I need your commit to test this?

@van800
Copy link
Collaborator

van800 commented Oct 18, 2023

The test project is for me and for the QA.

This fix would be released after 2023.3 EAP4.
Unfortunately there is a braking change in the API, so it is not compatible with EAP3.
Let me see if I can backport to 2023.2 ...

@van800
Copy link
Collaborator

van800 commented Oct 18, 2023

Plugin with this fix published for Rider 2023.2 (plugin version 2023.2.125)

@van800
Copy link
Collaborator

van800 commented Oct 18, 2023

Thank you for reporting @dotlogix

@van800 van800 closed this as completed Oct 18, 2023
@dotlogix
Copy link
Author

dotlogix commented Oct 18, 2023

@van800 it unfortunately does not work if the project is part of a solution folder check this out:
test.zip

Should I create a seperate issue for this one?

@van800
Copy link
Collaborator

van800 commented Oct 18, 2023

No need for a separate issue. Thank you!

@van800
Copy link
Collaborator

van800 commented Oct 18, 2023

2023.2.126 with fix for the solution folder case was just published.

@dotlogix
Copy link
Author

I can confirm that all of my issues are resolved now thx a lot <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants