Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -490,17 +490,18 @@ internal class ComposeSceneMediator(

unsubscribe(contentComponent)

interopContainer.root.removeContainerListener(interopContainerListener)
// Since rendering will not happen after, we need to execute all scheduled updates
interopContainer.dispose()

container.remove(contentComponent)
container.remove(invisibleComponent)
container.transferHandler = null
container.dropTarget = null

scene.close()
skiaLayerComponent.dispose()

interopContainer.root.removeContainerListener(interopContainerListener)
// Since rendering will not happen after, we need to execute all scheduled updates
interopContainer.dispose()

_onComponentAttached = null
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ import javax.swing.JFrame
import javax.swing.JPanel
import junit.framework.TestCase.assertTrue
import kotlin.test.assertEquals
import kotlin.test.assertFalse
import kotlinx.coroutines.delay
import kotlinx.coroutines.runBlocking
import org.jetbrains.skiko.ExperimentalSkikoApi
Expand Down Expand Up @@ -508,4 +509,40 @@ class ComposePanelTest {
window.dispose()
}
}

@Test
fun `ComposePanel clears SwingPanels when removed`() = runApplicationTest {
val jPanels = mutableListOf<JPanel>()
val composePanel = ComposePanel()
composePanel.setContent {
SwingPanel(
factory = {
JPanel().also {
it.size = Dimension(100, 100)
jPanels.add(it)
}
},
modifier = Modifier.size(100.dp)
)
}

val window = JFrame()
window.size = Dimension(200, 200)
try {
window.contentPane.add(composePanel, BorderLayout.CENTER)
window.isVisible = true
awaitIdle()
window.contentPane.remove(composePanel)
awaitIdle()
window.contentPane.add(composePanel)
awaitIdle()

assertEquals(2, jPanels.size)
assertFalse(composePanel.isAncestorOf(jPanels[0]))
assertTrue(composePanel.isAncestorOf(jPanels[1]))
assertTrue(jPanels[1].isShowing)
} finally {
window.dispose()
}
}
}