Skip to content

Conversation

@sokomishalov
Copy link
Contributor

@sokomishalov sokomishalov commented Jul 21, 2025

Description

Summary of the change:
Enable "SELECT FOR UPDATE" for the several applicable dialects

Detailed description:
It turned out that it's impossible to apply select for update for non-postgesql dialects, even though they are declared in ForUpdateOption


Type of Change

Please mark the relevant options with an "X":

  • Bug fix
  • New feature
  • Documentation update

Updates/remove existing public API methods:

  • Is breaking change

Affected databases:

  • MariaDB
  • Mysql5
  • Mysql8
  • Oracle
  • Postgres
  • SqlServer
  • H2
  • SQLite

Checklist

  • Unit tests are in place
  • The build is green (including the Detekt check)
  • All public methods affected by my PR has up to date API docs
  • Documentation for my change is up to date

Related Issues

@obabichevjb
Copy link
Collaborator

@sokomishalov Thank you for submitting the PR. Actually, the parameter supportsSelectForUpdate was moved to other place during preparation of Exposed 1.0.0, but it was not updated for select for update modifier.

I'll run CI for you PR and merge it if everything ok, but I hope that eventually we will remove the parameter you extended in favor of the new one.

@obabichevjb obabichevjb self-assigned this Jul 22, 2025
@sokomishalov
Copy link
Contributor Author

@obabichevjb sure, thanks a lot!

p.s. do you have any timeline for delivering next beta and approximate date for delivering stable 1.0?

@obabichevjb
Copy link
Collaborator

In general we have ~monthly releases, but with 1.0.0 preparation we deliver a bit more often (4 releases from mid of May)

For stable 1.0 there is no particular date, because it depends on solving the critical issues and stabilizing API.

@obabichevjb
Copy link
Collaborator

Could you also run the command gradle apiDump to update API spec, and check gradle detekt for linter check? If there are any changes (and with the first command it should be) could you add it also?

@sokomishalov sokomishalov force-pushed the feature/select-for-update-mysql branch from 4cfa955 to b3192f1 Compare July 22, 2025 08:31
@sokomishalov-jp
Copy link
Contributor

sure, updated

@sokomishalov sokomishalov force-pushed the feature/select-for-update-mysql branch from b3192f1 to e4c6315 Compare July 22, 2025 09:58
@obabichevjb obabichevjb merged commit 3ad844c into JetBrains:main Jul 22, 2025
4 checks passed
@obabichevjb
Copy link
Collaborator

@sokomishalov Thank you for the fix, it would help people who rely on select for update. It should be delivered with the next version 1.0.0-beta-5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants