refactor: Separate multiple internal classes from single file #2564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Address multiple todos that mostly don't affect the API too much
bog-walk
commented
Jul 18, 2025
Comment on lines
-65
to
-66
| @Suppress("ForbiddenComment") | ||
| // TODO: move to the utility class, rename |
Member
Author
There was a problem hiding this comment.
I believe the intention behind this TODO was that these functions could ultimately be testable in isolation. But I could be recalling wrong.
I'm not sure about the 'renaming' or what the more descriptive name would be? 🤔
Collaborator
There was a problem hiding this comment.
Hm.. about renaming I'm also not sure what was the particular plan..
bog-walk
commented
Jul 18, 2025
Comment on lines
+15
to
+16
| @InternalApi | ||
| object ExposedMetadataUtils { |
Member
Author
There was a problem hiding this comment.
As in the previous comment, I left this as public, but marked for internal use, because I think the intention was to eventually be able to test these methods.
If that's not the case, please suggest a different modifier or even a naming change!
obabichevjb
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change: Address TODOS involving moving/extracting of internal Exposed objects.
Detailed description:
SchemaUtilityApilog messages properties moved to companion objectSchemaUtilityApi.TableDepthGraphmoved to separate file as internal classExposedMetadataUtilsintroducedExposedDatabaseMetadatamethods into that object & adjust usagesCoreTransactionManagerto its own file, along with private classType of Change
Please mark the relevant options with an "X":