chore!: EXPOSED-813 When is the plan to migrate kotlinx.datetime.Instant to kotlin.time.Instant? #2557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ant to kotlin.time.Instant?
obabichevjb
force-pushed
the
obabichev/exposed-813-migrate-instant
branch
from
91ecabe to
c8812f0
Compare
obabichevjb
commented
Jul 11, 2025
| joda-time = "2.14.0" | ||
| junit = "4.13.2" | ||
| kotlinx-datetime = "0.6.2" | ||
| kotlinx-datetime = "0.7.1-0.6.x-compat" |
Collaborator
Author
There was a problem hiding this comment.
I took compat version to have original Instant inside kotlinx.datetime. Otherwise it would be typealias to kotlin.time.Instant, and our api spec generator updates APIs and changes type of Instant to the kotlin.time.Instant
e5l
approved these changes
Jul 14, 2025
bog-walk
approved these changes
Jul 15, 2025
Member
bog-walk
left a comment
bog-walk
left a comment
There was a problem hiding this comment.
Just 3 things to consider adding:
- (as mentioned above) Section in 1.0.0 migration guide
- Missing deprecation on
XKotlinInstantColumnType - Link to official library section in deprecation message for more details
...ed-kotlin-datetime/src/main/kotlin/org/jetbrains/exposed/v1/datetime/KotlinDateColumnType.kt
Show resolved
Hide resolved
...ed-kotlin-datetime/src/main/kotlin/org/jetbrains/exposed/v1/datetime/KotlinDateColumnType.kt
Show resolved
Hide resolved
...sed-kotlin-datetime/src/main/kotlin/org/jetbrains/exposed/v1/datetime/KotlinDateFunctions.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migration of
kotlinx.datetimefrom version 6 to version 7Type of Change
Updates/remove existing public API methods:
Affected databases:
Related Issues
EXPOSED-813 When is the plan to migrate kotlinx.datetime.Instant to kotlin.time.Instant?