-
Notifications
You must be signed in to change notification settings - Fork 751
docs: EXPOSED-747 Add a get started tutorial for Exposed DAO #2556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far, just some request for the code samples
documentation-website/Writerside/snippets/get-started-with-exposed-dao/README.md
Outdated
Show resolved
Hide resolved
documentation-website/Writerside/topics/Get-started-with-Exposed-DAO.md
Outdated
Show resolved
Hide resolved
documentation-website/Writerside/topics/Get-started-with-Exposed-DAO.md
Outdated
Show resolved
Hide resolved
documentation-website/Writerside/topics/Get-started-with-Exposed-DAO.md
Outdated
Show resolved
Hide resolved
documentation-website/Writerside/topics/Get-started-with-Exposed-DAO.md
Outdated
Show resolved
Hide resolved
documentation-website/Writerside/topics/Get-started-with-Exposed-DAO.md
Outdated
Show resolved
Hide resolved
documentation-website/Writerside/topics/Get-started-with-Exposed-DAO.md
Outdated
Show resolved
Hide resolved
documentation-website/Writerside/topics/Get-started-with-Exposed-DAO.md
Outdated
Show resolved
Hide resolved
|
Thanks for the review @bog-walk 🙏 I updated the code examples, added the suggested notes and included the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned a missing output change. Thanks for putting this together!
documentation-website/Writerside/snippets/get-started-with-exposed/README.md
Outdated
Show resolved
Hide resolved
documentation-website/Writerside/topics/Get-Started-with-Exposed.topic
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I've suggested some low-level changes.
Description
Add a new "Get started with Exposed's DAO API" tutorial to mirror the "Get started with Exposed" tutorial.
Additionally:
get-started-with-exposed-dao.get-started-with-exposedto the snippets project.Getting-Started-with-Exposed.topicfile to match the title.Type of Change
Please mark the relevant options with an "X":
Related Issues
EXPOSED-747