Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring before the release #321

Conversation

arksap2002
Copy link
Collaborator

@arksap2002 arksap2002 commented Aug 20, 2024

Description of changes made

Huge refactoring before a new release. The main points to fix are:

  1. Remove services to avoid global classes
  2. Remove helpers
  3. Refator desplay folder to improve the implementation structure and remove common code

For reviewers

This implementation is similar to #196, but with the kotlin implementation. I tried to fix merge conflicts, but I found easier to implement it again, because of the big project structure changings.
This PR contains a lot of modified lined, the main reason is the files paths changings. I separated my implementation in logical commits, I think it's better to go throught them one by one.

New display structure

Screenshot 2024-08-22 at 4 19 34 PM

Closed issues

#208
#322

  • I have checked that I am merging into correct branch

@arksap2002 arksap2002 changed the title Remove services and helpers Refactoring before the release Aug 22, 2024
@arksap2002 arksap2002 marked this pull request as ready for review August 22, 2024 14:29
@arksap2002 arksap2002 added the Urgent Urgant PR label Aug 22, 2024
@arksap2002 arksap2002 added bug Something isn't working Ready for review PR redy for review labels Aug 22, 2024
Copy link
Collaborator

@pderakhshanfar pderakhshanfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a set of minor comments. I will approve the PR when they are addressed. Thanks :)

@arksap2002 arksap2002 merged commit 945c7a8 into ebraun/bugs/psi-related-bugs/top-level-function Aug 28, 2024
2 checks passed
@arksap2002 arksap2002 deleted the arksap2002/refactoring/remove-services branch August 28, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for review PR redy for review Urgent Urgant PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants