Repository navigation
Fix fork CI: native xcframework target, skip macOS app - #5
Merged
Merged
Conversation
Jesssullivan
added a commit
that referenced
this pull request
Apr 18, 2026
The macOS build ships a system.tree RPC that flattens the entire UI hierarchy
into a single response so clients (CLIs, shell prompts, status bars) can avoid
N+1 round-trips. Linux currently exposes the leaf RPCs (window.list,
workspace.list, surface.list, pane.list) but not the composed view.
Add handleSystemTree mirroring the macOS shape:
active: { workspace_id, surface_id, window_id } // matches identify
windows[]: { id, ref, index, workspace_count, selected_workspace_id,
workspaces[]: { id, ref, index, title, selected, pinned,
panes[]: { id, ref, index, focused, surface_count,
selected_surface_id, surfaces[]: {
id, ref, index, index_in_pane, type,
focused, selected, selected_in_pane,
pane_id, pane_ref, title } } } }
Linux uses 1:1 panel:pane today, so each pane has exactly one surface and
pane.id == surface.id. The shape leaves room for future pane grouping
(multiple surfaces per pane) without breaking clients.
The handler is alloc-free in the steady-state error path: every writer.* call
that fails returns the same canonical empty envelope so partial responses
never leak. Workspace and panel titles flow through writeJsonString to keep
user-supplied strings safe.
The new socket round-trip test creates an extra workspace, asserts the
envelope, restores the baseline workspace selection, and closes the
scratch workspace in a finally block so it never leaves stale state.
Sprint A item #5 from #220 (TIN-183 follow-up after #218 / #221 / #222).
This was referenced Apr 18, 2026
Jesssullivan
added a commit
that referenced
this pull request
Apr 18, 2026
The macOS build ships a system.tree RPC that flattens the entire UI hierarchy
into a single response so clients (CLIs, shell prompts, status bars) can avoid
N+1 round-trips. Linux currently exposes the leaf RPCs (window.list,
workspace.list, surface.list, pane.list) but not the composed view.
Add handleSystemTree mirroring the macOS shape:
active: { workspace_id, surface_id, window_id } // matches identify
windows[]: { id, ref, index, workspace_count, selected_workspace_id,
workspaces[]: { id, ref, index, title, selected, pinned,
panes[]: { id, ref, index, focused, surface_count,
selected_surface_id, surfaces[]: {
id, ref, index, index_in_pane, type,
focused, selected, selected_in_pane,
pane_id, pane_ref, title } } } }
Linux uses 1:1 panel:pane today, so each pane has exactly one surface and
pane.id == surface.id. The shape leaves room for future pane grouping
(multiple surfaces per pane) without breaking clients.
The handler is alloc-free in the steady-state error path: every writer.* call
that fails returns the same canonical empty envelope so partial responses
never leak. Workspace and panel titles flow through writeJsonString to keep
user-supplied strings safe.
The new socket round-trip test creates an extra workspace, asserts the
envelope, restores the baseline workspace selection, and closes the
scratch workspace in a finally block so it never leaves stale state.
Sprint A item #5 from #220 (TIN-183 follow-up after #218 / #221 / #222).
Jesssullivan
added a commit
that referenced
this pull request
Apr 18, 2026
#223) The macOS build ships a system.tree RPC that flattens the entire UI hierarchy into a single response so clients (CLIs, shell prompts, status bars) can avoid N+1 round-trips. Linux currently exposes the leaf RPCs (window.list, workspace.list, surface.list, pane.list) but not the composed view. Add handleSystemTree mirroring the macOS shape: active: { workspace_id, surface_id, window_id } // matches identify windows[]: { id, ref, index, workspace_count, selected_workspace_id, workspaces[]: { id, ref, index, title, selected, pinned, panes[]: { id, ref, index, focused, surface_count, selected_surface_id, surfaces[]: { id, ref, index, index_in_pane, type, focused, selected, selected_in_pane, pane_id, pane_ref, title } } } } Linux uses 1:1 panel:pane today, so each pane has exactly one surface and pane.id == surface.id. The shape leaves room for future pane grouping (multiple surfaces per pane) without breaking clients. The handler is alloc-free in the steady-state error path: every writer.* call that fails returns the same canonical empty envelope so partial responses never leak. Workspace and panel titles flow through writeJsonString to keep user-supplied strings safe. The new socket round-trip test creates an extra workspace, asserts the envelope, restores the baseline workspace selection, and closes the scratch workspace in a finally block so it never leaves stale state. Sprint A item #5 from #220 (TIN-183 follow-up after #218 / #221 / #222).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Universal xcframework build fails on GitHub-hosted runners (DockTilePlugin x86_64 Swift compile). Use native target + skip macos app (matching upstream's -Demit-macos-app=false).