Skip to content

Fix remaining nonisolated static methods #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jesssullivan merged 1 commit into from
Mar 22, 2026
Merged

Fix remaining nonisolated static methods #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/Panels/WebAuthnCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ final class WebAuthnCoordinator: NSObject {

/// Parse a single CBOR value starting at the given offset.
/// Returns the parsed value and the new offset, or nil on failure.
private static func parseCBORValue(bytes: [UInt8], offset: Int) -> (Any?, Int?) {
private nonisolated static func parseCBORValue(bytes: [UInt8], offset: Int) -> (Any?, Int?) {
guard offset < bytes.count else { return (nil, nil) }
let header = bytes[offset]
let majorType = header >> 5
Expand Down Expand Up @@ -573,7 +573,7 @@ final class WebAuthnCoordinator: NSObject {
}

/// Parse a CBOR unsigned integer (major type 0) at offset.
private static func parseCBORUInt(bytes: [UInt8], offset: Int) -> (Int?, Int?) {
private nonisolated static func parseCBORUInt(bytes: [UInt8], offset: Int) -> (Int?, Int?) {
guard offset < bytes.count else { return (nil, nil) }
let additional = bytes[offset] & 0x1f
guard let (value, newOff) = parseCBORRawUInt(bytes: bytes, offset: offset + 1, additional: additional) else {
Expand All @@ -583,7 +583,7 @@ final class WebAuthnCoordinator: NSObject {
}

/// Parse the raw unsigned integer value from CBOR additional info.
private static func parseCBORRawUInt(bytes: [UInt8], offset: Int, additional: UInt8) -> (UInt64, Int)? {
private nonisolated static func parseCBORRawUInt(bytes: [UInt8], offset: Int, additional: UInt8) -> (UInt64, Int)? {
if additional < 24 {
return (UInt64(additional), offset)
} else if additional == 24 {
Expand Down
Loading