Skip to content

change na to n_atmsteps#2

Merged
JessicaMeixner-NOAA merged 1 commit into
JessicaMeixner-NOAA:JDM/feature/p8b-aerofrom
junwang-noaa:fv32phs
Mar 4, 2022
Merged

change na to n_atmsteps#2
JessicaMeixner-NOAA merged 1 commit into
JessicaMeixner-NOAA:JDM/feature/p8b-aerofrom
junwang-noaa:fv32phs

Conversation

@junwang-noaa
Copy link
Copy Markdown

Description

Add variable name change: na->n_atmsteps for readability.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit b71a125 into JessicaMeixner-NOAA:JDM/feature/p8b-aero Mar 4, 2022
@junwang-noaa junwang-noaa deleted the fv32phs branch September 16, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants