Skip to content

Add convection tuning parameters to namelist#8

Merged
JessicaMeixner-NOAA merged 1 commit into
JessicaMeixner-NOAA:feature/updatemod1114from
lisa-bengtsson:convection_param
Nov 15, 2023
Merged

Add convection tuning parameters to namelist#8
JessicaMeixner-NOAA merged 1 commit into
JessicaMeixner-NOAA:feature/updatemod1114from
lisa-bengtsson:convection_param

Conversation

@lisa-bengtsson
Copy link
Copy Markdown

Add convection tuning parameters to namelist, default values are for SAS in HR prototypes 1 through 3.

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Owner

@lisa-bengtsson should this coincide with a model update as well?

@lisa-bengtsson
Copy link
Copy Markdown
Author

Yes, do I update this in the checkout script? e.g. point to a new hash?

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Owner

Yes, but we'll have to wait until the PR is merged to get that new hash.

@lisa-bengtsson
Copy link
Copy Markdown
Author

ok, yes, I will keep an eye out for the new hash and then update this PR - hang tight!

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Owner

@lisa-bengtsson sounds good! In the meantime I looked at the PR and I don't think there are other updates to make from that PR - but thought I'd double check. All the other updates to the input shouldn't need updated here to my understanding.

@lisa-bengtsson
Copy link
Copy Markdown
Author

That is my understanding as well. The ones pertaining to gravity wave drag are for a different application. Only these 3 parameters in this PR concern HR3.

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit e9945e5 into JessicaMeixner-NOAA:feature/updatemod1114 Nov 15, 2023
@JessicaMeixner-NOAA
Copy link
Copy Markdown
Owner

@lisa-bengtsson I merged this in and will update the model hash, run a quick test and submit the PR!

@lisa-bengtsson
Copy link
Copy Markdown
Author

Thank you!

JessicaMeixner-NOAA pushed a commit that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants