DON'T MERGE YET: Seaice DA, needs the GDASApp PR merged first. #12
Closed
guillaumevernieres wants to merge 7 commits into
Closed
Conversation
| local seconds | ||
| seconds=$(to_seconds "${restart_date:8:2}0000") # convert HHMMSS to seconds | ||
| cice_restart_file="${DATArestart}/CICE_RESTART/cice_model.res.${restart_date:0:4}-${restart_date:4:2}-${restart_date:6:2}-${seconds}.nc" | ||
| if [[ "${DO_JEDIOCNVAR:-NO}" = "YES" && "${restart_date}" = "${sdate_current_cycle}" ]]; then |
There was a problem hiding this comment.
@guillaumevernieres Two things, one i changed the sdate_current_cycle name on you to be: model_start_date_current_cycle -- sorry!
And 2, I don't think you can have RERUN=YES if restart_date=model_start_date_current_cycle, so I don't think this is a needed block.... but we should get someone else to confirm.
Author
There was a problem hiding this comment.
arf ... yes, you also told me about it. I'll remove the block too.
Author
There was a problem hiding this comment.
did you push that change @JessicaMeixner-NOAA ? I don't see model_start_date_current_cycle defined anywhere.
There was a problem hiding this comment.
just pushed.. sorry i thought i had
Owner
|
Closing... This branch is now in develop. |
JessicaMeixner-NOAA
pushed a commit
that referenced
this pull request
Apr 14, 2025
fix parsing_ufs_configure.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.