Skip to content

fix(release): strip x86_64 slice from Sparkle's Autoupdate before signing (fixes #309) #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
praxstack wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(release): strip x86_64 slice from Sparkle's Autoupdate before signing (fixes #309) #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions scripts/release_dmg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,13 @@ if [[ -d "${SPARKLE_DIR}" ]]; then
"${SPARKLE_DIR}/XPCServices/Downloader.xpc"
fi
if [[ -f "${SPARKLE_DIR}/Autoupdate" ]]; then
# Sparkle ships Autoupdate as a universal (arm64+x86_64) binary even in
# its latest release. Dayflow itself is arm64-only, so the leftover
# x86_64 slice serves no purpose here and triggers macOS's "Support
# Ending for Intel-based Apps" deprecation warning on Apple Silicon.
if lipo -info "${SPARKLE_DIR}/Autoupdate" 2>/dev/null | grep -q x86_64; then
lipo -thin arm64 "${SPARKLE_DIR}/Autoupdate" -output "${SPARKLE_DIR}/Autoupdate"
fi
codesign -vvv --force -o runtime --sign "${SIGN_ID}" \
"${SPARKLE_DIR}/Autoupdate"
fi
Expand Down