fix: forward template cancellation tokens#468
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Template source generator to correctly forward CancellationToken to synchronous hooks/steps when an async wrapper (ExecuteAsync) is generated, and adds TinyBDD scenarios to cover the new emission paths and a missing-context diagnostic (per #413 coverage goals).
Changes:
- Forward
CancellationTokento sync template hooks/steps inside the generated async wrapper when the target member declares aCancellationTokenparameter. - Add generator tests ensuring forwarding occurs across before/step/after/on-error paths.
- Add generator test coverage for a step method that lacks a required context parameter (PKTMP004).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/PatternKit.Generators/TemplateGenerator.cs |
Updates async wrapper emission to pass ct to sync hooks/steps when applicable. |
test/PatternKit.Generators.Tests/TemplateGeneratorTests.cs |
Adds TinyBDD scenarios covering cancellation token forwarding and missing-context diagnostics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+569
to
+571
| var hasCt = hook.Method.Parameters.Any(IsCancellationToken); | ||
| var args = hasCt ? "ctx, ct" : "ctx"; | ||
| sb.AppendLine($" {hook.Method.Name}({args});"); |
Contributor
Test Results 12 files 12 suites 10m 48s ⏱️ Results for commit 92984d5. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 97.03% 97.17% +0.13%
==========================================
Files 579 579
Lines 47168 47180 +12
Branches 3088 6768 +3680
==========================================
+ Hits 45768 45845 +77
+ Misses 1400 1335 -65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
JerrettDavis
force-pushed
the
coverage/harden-generator-gaps-413-d
branch
from
May 31, 2026 04:21
4c7dbbd to
92984d5
Compare
Contributor
Code Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #413.
Summary
Validation