test(generators): cover dead letter and mailbox#441
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands Mailbox and Dead Letter Channel generator coverage while adding nested host wrapper emission so generated factories can live inside containing partial types.
Changes:
- Converts the two generator test suites to TinyBDD scenario chains.
- Adds diagnostics/configuration/default/nested-host coverage for mailbox and dead-letter generators.
- Updates both generators to emit containing partial type wrappers for nested hosts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/PatternKit.Generators/Messaging/MailboxGenerator.cs |
Adds nested containing-type wrapper generation for mailbox sources. |
src/PatternKit.Generators/Messaging/DeadLetterChannelGenerator.cs |
Adds nested containing-type wrapper generation for dead-letter channel sources. |
test/PatternKit.Generators.Tests/MailboxGeneratorTests.cs |
Reworks mailbox tests into TinyBDD scenarios and expands behavior coverage. |
test/PatternKit.Generators.Tests/DeadLetterChannelGeneratorTests.cs |
Reworks dead-letter tests into TinyBDD scenarios and expands behavior coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sb.Append("abstract "); | ||
| else if (type.IsSealed && type.TypeKind == TypeKind.Class) | ||
| sb.Append("sealed "); | ||
| sb.Append("partial ").Append(type.TypeKind == TypeKind.Struct ? "struct" : "class").Append(' ').Append(type.Name); |
| sb.AppendLine(" .Build();"); | ||
| sb.AppendLine("}"); | ||
| return sb.ToString(); | ||
| sb.Append("partial ").Append(type.TypeKind == TypeKind.Struct ? "struct" : "class").Append(' ').Append(type.Name); |
Contributor
Test Results 12 files 12 suites 9m 56s ⏱️ Results for commit c490748. |
Contributor
Code Coverage |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
+ Coverage 91.22% 96.62% +5.40%
==========================================
Files 551 551
Lines 44763 44820 +57
Branches 6448 6458 +10
==========================================
+ Hits 40835 43309 +2474
+ Misses 1615 1511 -104
+ Partials 2313 0 -2313
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Refs #413