test: cover unit of work generator hosts#428
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the Unit of Work source generator’s correctness surface (notably for nested generator hosts) while converting the UnitOfWork generator test suite to TinyBDD xUnit scenarios to significantly increase coverage.
Changes:
- Updated
UnitOfWorkGeneratorto emit containing-type wrapper declarations so nested[GenerateUnitOfWork]hosts generate into the correct nested scope. - Reworked
UnitOfWorkGeneratorTestsinto TinyBDD scenarios and expanded coverage across ordering, diagnostics, escaping, host shapes, nested accessibility wrappers, and emit success.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/PatternKit.Generators/UnitOfWork/UnitOfWorkGenerator.cs |
Emits containing-type wrappers and refactors emission indentation to support nested generator hosts. |
test/PatternKit.Generators.Tests/UnitOfWorkGeneratorTests.cs |
Converts tests to TinyBDD xUnit scenarios and adds broader diagnostic + emission coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+165
to
+171
| if (type.IsStatic) | ||
| sb.Append("static "); | ||
| else if (type.IsAbstract && type.TypeKind == TypeKind.Class) | ||
| sb.Append("abstract "); | ||
| else if (type.IsSealed && type.TypeKind == TypeKind.Class) | ||
| sb.Append("sealed "); | ||
| sb.Append("partial ").Append(type.TypeKind == TypeKind.Struct ? "struct" : "class").Append(' ').Append(type.Name); |
Comment on lines
+113
to
+117
| var containingTypes = GetContainingTypes(type); | ||
| var indentLevel = 0; | ||
| foreach (var containingType in containingTypes) | ||
| { | ||
| AppendTypeDeclaration(sb, containingType, indentLevel); |
Contributor
Test Results 12 files 12 suites 9m 54s ⏱️ Results for commit a964cb9. |
Contributor
Code Coverage |
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
+ Coverage 90.18% 96.05% +5.87%
==========================================
Files 551 551
Lines 44291 44311 +20
Branches 6373 6376 +3
==========================================
+ Hits 39945 42565 +2620
+ Misses 1884 1746 -138
+ Partials 2462 0 -2462
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Coverage:
Validation:
Closes part of #413.