Skip to content

refactor: reuse MCP discovery chain#66

Merged
JerrettDavis merged 1 commit into
mainfrom
simplify-patternkit-mcp-registry
Jun 2, 2026
Merged

refactor: reuse MCP discovery chain#66
JerrettDavis merged 1 commit into
mainfrom
simplify-patternkit-mcp-registry

Conversation

@JerrettDavis

Copy link
Copy Markdown
Owner

Summary

  • build the PatternKit MCP discovery chain once in the registry constructor
  • keep per-call merge state isolated
  • avoid rebuilding provider pipeline plumbing on every discovery call

Validation

  • dotnet test tests\JD.SemanticKernel.Extensions.Mcp.Tests\JD.SemanticKernel.Extensions.Mcp.Tests.csproj --configuration Release --no-restore
  • git diff --check

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot added the size/s label Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Code Coverage

Summary
  Generated on: 06/02/2026 - 03:06:47
  Coverage date: 06/02/2026 - 03:06:40 - 06/02/2026 - 03:06:45
  Parser: MultiReport (8x Cobertura)
  Assemblies: 7
  Classes: 59
  Files: 56
  Line coverage: 74.5%
  Covered lines: 1339
  Uncovered lines: 457
  Coverable lines: 1796
  Total lines: 5078
  Branch coverage: 59.5% (492 of 826)
  Covered branches: 492
  Total branches: 826
  Method coverage: 85.2% (225 of 264)
  Full method coverage: 71.5% (189 of 264)
  Covered methods: 225
  Fully covered methods: 189
  Total methods: 264

JD.SemanticKernel.Extensions.Compaction                                          98.1%
  JD.SemanticKernel.Extensions.Compaction.CompactionFilter                        100%
  JD.SemanticKernel.Extensions.Compaction.CompactionOptions                       100%
  JD.SemanticKernel.Extensions.Compaction.ContextPercentageTrigger               87.5%
  JD.SemanticKernel.Extensions.Compaction.HierarchicalSummarizationStrategy      97.7%
  JD.SemanticKernel.Extensions.Compaction.ServiceCollectionExtensions             100%
  JD.SemanticKernel.Extensions.Compaction.TokenEstimator                          100%
  JD.SemanticKernel.Extensions.Compaction.TokenThresholdTrigger                   100%

JD.SemanticKernel.Extensions.Hooks                                               76.5%
  JD.SemanticKernel.Extensions.Hooks.CommandHookExecutor                            0%
  JD.SemanticKernel.Extensions.Hooks.ExtensionEvent                               100%
  JD.SemanticKernel.Extensions.Hooks.ExtensionEventBus                            100%
  JD.SemanticKernel.Extensions.Hooks.HookBuilder                                  100%
  JD.SemanticKernel.Extensions.Hooks.HookDefinition                               100%
  JD.SemanticKernel.Extensions.Hooks.HookParser                                  83.9%
  JD.SemanticKernel.Extensions.Hooks.KernelBuilderExtensions                     32.2%
  JD.SemanticKernel.Extensions.Hooks.SkHookFilter                                 100%
  JD.SemanticKernel.Extensions.Hooks.SkPromptHookFilter                           100%

JD.SemanticKernel.Extensions.Mcp                                                 60.4%
  JD.SemanticKernel.Extensions.Mcp.Discovery.ClaudeCodeMcpDiscoveryProvider       100%
  JD.SemanticKernel.Extensions.Mcp.Discovery.ClaudeDesktopMcpDiscoveryProvider    4.3%
  JD.SemanticKernel.Extensions.Mcp.Discovery.CodexMcpDiscoveryProvider           18.1%
  JD.SemanticKernel.Extensions.Mcp.Discovery.CopilotMcpDiscoveryProvider          4.7%
  JD.SemanticKernel.Extensions.Mcp.Discovery.FileMcpDiscoveryProvider            92.8%
  JD.SemanticKernel.Extensions.Mcp.Discovery.JdCanonicalMcpDiscoveryProvider     93.1%
  JD.SemanticKernel.Extensions.Mcp.Discovery.McpConfigParser                     73.9%
  JD.SemanticKernel.Extensions.Mcp.Discovery.VsCodeMcpDiscoveryProvider          86.6%
  JD.SemanticKernel.Extensions.Mcp.KernelBuilderMcpExtensions                       0%
  JD.SemanticKernel.Extensions.Mcp.KernelIntegration.McpKernelPluginFactory         0%
  JD.SemanticKernel.Extensions.Mcp.McpClientRegistry                                0%
  JD.SemanticKernel.Extensions.Mcp.McpInvocationResult                            100%
  JD.SemanticKernel.Extensions.Mcp.McpServerDefinition                            100%
  JD.SemanticKernel.Extensions.Mcp.McpToolDefinition                              100%
  JD.SemanticKernel.Extensions.Mcp.McpToolParameter                              93.3%
  JD.SemanticKernel.Extensions.Mcp.Registry.McpRegistry                           100%
  JD.SemanticKernel.Extensions.Mcp.Transport.HttpMcpClient                       87.6%
  JD.SemanticKernel.Extensions.Mcp.Transport.McpResponseParser                   90.3%
  JD.SemanticKernel.Extensions.Mcp.Transport.StdioMcpClient                      56.5%

JD.SemanticKernel.Extensions.Memory                                              94.5%
  JD.SemanticKernel.Extensions.Memory.InMemoryBackend                            96.1%
  JD.SemanticKernel.Extensions.Memory.MemoryRecord                                100%
  JD.SemanticKernel.Extensions.Memory.MemoryResult                                100%
  JD.SemanticKernel.Extensions.Memory.MemorySearchOptions                         100%
  JD.SemanticKernel.Extensions.Memory.MmrReranker                                96.9%
  JD.SemanticKernel.Extensions.Memory.QueryExpander                               100%
  JD.SemanticKernel.Extensions.Memory.SemanticMemory                             92.5%
  JD.SemanticKernel.Extensions.Memory.SemanticMemoryOptions                       100%
  JD.SemanticKernel.Extensions.Memory.ServiceCollectionExtensions                76.9%
  JD.SemanticKernel.Extensions.Memory.TemporalDecayScorer                         100%

JD.SemanticKernel.Extensions.Memory.Sqlite                                       94.9%
  JD.SemanticKernel.Extensions.Memory.Sqlite.ServiceCollectionExtensions          100%
  JD.SemanticKernel.Extensions.Memory.Sqlite.SqliteMemoryBackend                 94.7%

JD.SemanticKernel.Extensions.Plugins                                             74.5%
  JD.SemanticKernel.Extensions.Plugins.KernelBuilderExtensions                      0%
  JD.SemanticKernel.Extensions.Plugins.LoadedPlugin                               100%
  JD.SemanticKernel.Extensions.Plugins.PluginDependencyResolver                   100%
  JD.SemanticKernel.Extensions.Plugins.PluginLoader                              96.8%
  JD.SemanticKernel.Extensions.Plugins.PluginLoadOptions                            0%
  JD.SemanticKernel.Extensions.Plugins.PluginManifest                             100%

JD.SemanticKernel.Extensions.Skills                                              84.1%
  JD.SemanticKernel.Extensions.Skills.KernelBuilderExtensions                       0%
  JD.SemanticKernel.Extensions.Skills.SkillDefinition                             100%
  JD.SemanticKernel.Extensions.Skills.SkillKernelFunction                         100%
  JD.SemanticKernel.Extensions.Skills.SkillLoader                                 100%
  JD.SemanticKernel.Extensions.Skills.SkillLoadOptions                              0%
  JD.SemanticKernel.Extensions.Skills.SkillParser                                97.2%

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Test Results

243 tests   217 ✅  6s ⏱️
  8 suites   26 💤
  8 files      0 ❌

Results for commit 143cad8.

@JerrettDavis JerrettDavis merged commit cdd01bb into main Jun 2, 2026
12 checks passed
@JerrettDavis JerrettDavis deleted the simplify-patternkit-mcp-registry branch June 2, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant