fix: add explicit StringComparison.Ordinal for MA0002 (Meziantou.Analyzer 3.0.138) - #65
Merged
Conversation
Meziantou.Analyzer 3.0.138 (bumped via Dependabot) enforces MA0002 for Assert.Contains<string> calls without an IEqualityComparer<string> parameter. StringComparer.Ordinal preserves the existing (default) equality behavior exactly, so test outcomes are unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Test Results184 tests 175 ✅ 1s ⏱️ Results for commit 59e1318. |
Contributor
Code Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot's Meziantou.Analyzer 3.0.125 -> 3.0.138 bump (#64) enables MA0002 for
Assert.Contains<string>collection-membership calls without anIEqualityComparer<string>parameter, which breaks the analyzers-as-errors build on this pre-existing test code.Fix: add
StringComparer.Ordinalexplicitly at the 28 flagged sites acrossClaudeModelDiscoveryTests.cs,CodebaseExplorerE2ETests.cs,GherkinGeneratorE2ETests.cs, andPullRequestReviewerE2ETests.cs. The default equality comparer for these string collection checks is already ordinal, so this preserves existing behavior exactly and does not change any test outcome.No production/src code touched. Build and full test suite (all test projects, net8.0/net10.0) verified green locally with the analyzer bump applied.
Once merged, the Dependabot PR (#64) can rebase and go green.