Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send mail settings: bypass_spam_management vs. SpamChecking #391

Closed
tmacht opened this issue May 6, 2021 · 3 comments
Closed

send mail settings: bypass_spam_management vs. SpamChecking #391

tmacht opened this issue May 6, 2021 · 3 comments
Assignees
Labels
Breaking Change This change causes backward compatibility issue(s)
Milestone

Comments

@tmacht
Copy link

tmacht commented May 6, 2021

How does the SpamChecking property of the MailSettings of the SendToSingleRecipientAsync method relate to the bypass_spam_management described here? https://sendgrid.api-docs.io/v3.0/mail-send/v3-mail-send

Because it seems that StrongGrid sends spam_check to SendGrid whereas the SendGrid documentation expects bypass_spam_management. Also, bypass_spam_management only has one field (enable), but SpamChecking has 3 (Enabled, PostToUrl, Threshold).

Thanks for all the good work!

@Jericho Jericho self-assigned this May 6, 2021
@Jericho
Copy link
Owner

Jericho commented May 6, 2021

I suspect SendGrid made some changes to their API at some point which would explain the discrepancy between the settings available in StrongGrid and the documentation you linked.

I searched their knowledge center and found an announcement dated January 2020 where they say they are retiring sparsely used mail settings including "Spam Checker". The announcement is not very detailed but I'm guessing the spam checker they mention corresponds to the spam checking property of the MailSettings in StrongGrid. The announcement doesn't mention anything about the new bypass_spam_management though.

I also found a page in their documentation that describes the Spam Checker settings that StrongGrid implements (i.e.: the enabled property, the threshold and the post URL) and it too alerts the reader that "this settings has been removed". No word on the new bypass_spam_management either.

I continued my research and found a December 2020 pull request in their documentation GitHub repo that adds documentation for "Bypass suppressions" (including bypass_spam_management). The section of the PR that is of interest to us corresponds to this page in their knowledge center.

My conclusion, based on the information I found and presented above, is that they made two changes to their API:

  • in early 2020 they removed the "Spam Checker" settings
  • in late 2020 they added "bypass suppression" settings.

I try to stay up to date with the changes they make to their API but, as you can see, it's not easy! Anyway, thanks for alerting me, I will make the necessary changes in StrongGrid and I will also double check it there are any other mail settings that have changed.

@Jericho Jericho added the Breaking Change This change causes backward compatibility issue(s) label May 6, 2021
@Jericho Jericho added this to the 0.81.0 milestone May 6, 2021
@Jericho
Copy link
Owner

Jericho commented May 6, 2021

I just discovered two more changes to SendGrid's mail send API: in August 2020, Sections and BCC mail settings were removed.

Jericho added a commit that referenced this issue May 7, 2021
Also mark GetBccMailSettingsAsync and UpdateBccMailSettingsAsync as obsolete
Jericho added a commit that referenced this issue May 7, 2021
Also mark GetSpamCheckMailSettingsAsync and UpdateSpamCheckMailSettingsAsync as obsolete
Jericho added a commit that referenced this issue May 7, 2021
Also add BypassSpamManagement, BypassBounceManagement and BypassUnsubscribeManagement.
Jericho added a commit that referenced this issue May 7, 2021
Also add BypassSpamManagement, BypassBounceManagement and BypassUnsubscribeManagement.
Jericho added a commit that referenced this issue May 8, 2021
Jericho added a commit that referenced this issue May 8, 2021
Also mark GetBccMailSettingsAsync and UpdateBccMailSettingsAsync as obsolete
Jericho added a commit that referenced this issue May 8, 2021
Also mark GetSpamCheckMailSettingsAsync and UpdateSpamCheckMailSettingsAsync as obsolete
Jericho added a commit that referenced this issue May 8, 2021
Also add BypassSpamManagement, BypassBounceManagement and BypassUnsubscribeManagement.
Jericho added a commit that referenced this issue May 8, 2021
@Jericho Jericho closed this as completed in c8684e8 May 8, 2021
@Jericho
Copy link
Owner

Jericho commented May 9, 2021

🎉 This issue has been resolved in version 0.81.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change This change causes backward compatibility issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants