util: Document why ArgsManager (con/de)structor is not inline

JeremyRubin · Apr 16, 2020 · faf989f · faf989f
1 parent fae00a7
commit faf989f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/util/settings.h b/src/util/settings.h
@@ -9,7 +9,7 @@
 #include <string>
 #include <vector>
 
-#include <univalue.h> // For util::SettingsValue = UniValue
+class UniValue;
 
 namespace util {
 

diff --git a/src/util/system.cpp b/src/util/system.cpp
@@ -226,10 +226,11 @@ static bool CheckValid(const std::string& key, const util::SettingsValue& val, u
     return true;
 }
 
-ArgsManager::ArgsManager()
-{
-    // nothing to do
-}
+// Define default constructor and destructor that are not inline, so code instantiating this class doesn't need to
+// #include class definitions for all members.
+// For example, m_settings has an internal dependency on univalue.
+ArgsManager::ArgsManager() {}
+ArgsManager::~ArgsManager() {}
 
 const std::set<std::string> ArgsManager::GetUnsuitableSectionOnlyArgs() const
 {

diff --git a/src/util/system.h b/src/util/system.h
@@ -192,6 +192,7 @@ class ArgsManager
 
 public:
     ArgsManager();
+    ~ArgsManager();
 
     /**
      * Select the network in use
-Original file line number
+Diff line change
@@ Expand Up / @@ -192,6 +192,7 @@ class ArgsManager @@
     public:
         ArgsManager();
+        ~ArgsManager();
         /**
          * Select the network in use
@@ Expand Down @@