Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version number to 0.3.5 #103

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update version number to 0.3.5 #103

wants to merge 5 commits into from

Conversation

JeremyCCHsu
Copy link
Owner

No description provided.

@sabonerune sabonerune mentioned this pull request Jan 21, 2025
Closed
@JeremyCCHsu
Copy link
Owner Author

Hey @sabonerune, thanks for #99. I tested it, but it seems that older Python doesn't have importlib_metadata out of the box. Therefore, I created this PR and keep pkg_resources instead for the version number. Let me know if that makes sense or if there are any suggestions.

@sabonerune
Copy link
Contributor

@JeremyCCHsu
I think in most cases using pkg_resources with Python < 3.8 is probably fine.
This is because Setuptools is typically expected to be installed by default on these versions.
Also, since Setuptools has dropped support for these Python versions, there is no need to worry about the API being broken.

It would be a problem if users manually uninstalled Setuptools, but I don't think they would normally do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeremyCCHsu @sabonerune