Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update historical_model.py #127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update historical_model.py #127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e061b57
Update historical_model.py
sword134 Mar 26, 2024
42f2c44
Merge branch 'main' into patch-1
JerBouma Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions financetoolkit/historical_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def worker(ticker, historical_data_dict):
sleep_timer=sleep_timer,
)

if not historical_data.empty:
if not historical_data.empty and not historical_data.isnull().all().all():
fmp_tickers.append(ticker)

if source == "YahooFinance" or historical_data.empty:
Expand All @@ -169,7 +169,7 @@ def worker(ticker, historical_data_dict):
if not historical_data.empty:
yf_tickers.append(ticker)

if historical_data.empty:
if historical_data.empty and not historical_data.isnull().all().all():
no_data.append(ticker)
historical_data_dict[ticker] = empty_historical_data
if not historical_data.empty:
Expand Down
Loading