Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements #12

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

jplitza
Copy link
Contributor

@jplitza jplitza commented Apr 8, 2023

Most importantly, I rewrote the CMK plugin to improve the readability of the service summary and introduce a prase function.

jplitza added 4 commits April 8, 2023 12:25
Makes the output much more Check_MK-like
* Honor $PATH (fixes JensKuehnel#6)
* Use xargs instead of for loop
* Use single awk instead of grep+sed
@dnlldl
Copy link

dnlldl commented Jun 11, 2024

any plans on making this work on 2.3?

@dnlldl
Copy link

dnlldl commented Jun 12, 2024

I just checked and it works with 2.3, however when updating the checkmk server, it seems to reinstall the package from last known mkp. The fix for me was just to repackage it (mkp release fail2ban, then mkp template fail2ban, and mkp package fail2ban.manifest.temp). From the doc: https://docs.checkmk.com/latest/en/mkps.html#release_mkp

I edited the manifest and put version 1.9.2 in there and was able to successfully make the new mkp work. It should survive the next checkmk update. Here is my manifest for anyone interested in quickly repackaging it:

{'author': 'JensKuehnel',
 'description': 'Monitor fail2ban jails',
 'download_url': 'https://github.com/FreifunkBremen/fail2ban-check-mk/tree/master',
 'files': {'agent_based': ['fail2ban_checks.py'],
           'agents': ['plugins/fail2ban'],
           'checkman': ['fail2ban'],
           'lib': ['check_mk/base/cee/plugins/bakery/fail2ban.py',
                   'python3/cmk/base/cee/plugins/bakery/fail2ban.py'],
           'web': ['plugins/metrics/fail2ban_metric.py',
                   'plugins/wato/fail2ban_parameters.py']},
 'name': 'fail2ban',
 'title': 'fail2ban',
 'version': '1.9.2',
 'version.min_required': '2.3.0p6',
 'version.packaged': 'cmk-mkp-tool 0.2.0',
 'version.usable_until': None}

After that, if you check with mkp list, you will see you are using that new 1.9.2 version. You can disable and remove 1.9.1.

@JensKuehnel JensKuehnel merged commit 2e2e666 into JensKuehnel:master Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants