Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMD_SCREEN_ON constant in accordance with #323 #325

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

Victor4X
Copy link
Contributor

@Victor4X Victor4X commented Nov 23, 2022

This implements the change mentioned in #323.

The original issue of not getting any information in HASS was caused by update()

async def update(self, get_running_apps=True, lazy=True):

using the lazy parameter in get_properties(), which doesn't retrieve any information unless the screen is on:
if lazy and not (screen_on and awake):

The change adds an additional way to check whether or not the screen is on, and should still function properly in older android versions.

More work is needed to determine the cause of periodic state:Off logs: #323 (comment)

@chatziko
Copy link

chatziko commented Dec 9, 2022

@JeffLIrion : could you please publish a new pypi release containing this fix?

@JeffLIrion
Copy link
Owner

@chatziko done!

@chatziko
Copy link

@JeffLIrion : many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants