Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More SimpleValue types are handled #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fbrosseau
Copy link
Contributor

  • Add ToArray to ClrDynamic
  • Add support for X509Certificate(2)
  • Add support for IPEndPoint

Francis Brosseau added 2 commits February 1, 2019 10:56
- Add support for X509Certificate(2)
- Add support for IPEndPoint
@JeffCyr
Copy link
Owner

JeffCyr commented Feb 5, 2019

Thanks for thoses changes, there is some nice ideas.

However I don't want to add too much stuff in SimpleValue, theses should only be primitive types, I added some more common types (TimeSpan, DateTime, etc) but it's a bit of a stretch already. An extensible ClrDynamic.ConvertTo<T>() method could make more sense here to add more complex types.

ToArray

I think ClrDynamic.ToArray should limit itself to primitive array types for now. I don't like the idea of mixing Visualizers in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants