Minor modifications to build on current OS X machine #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added a commit
that referenced
this pull request
May 13, 2013
Minor modifications to build on current OS X machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the path to the Carbon headers, which has changed with recent XCode versions. It is configurable by the CARBON_HEADERS environment variable. I also wrapped the BITS32/64 define in a check to see whether one is already defined, since BIT64 is set in Makefile.macosx. The check around SIZEOF_POINTER was failing even when it was defined... not sure why. It happened GCC 4.2.1, GCC 4.7.2 and Clang 4.2 (LLVM 3.2).