Skip to content

Fixing docker crash changing world in harmonic #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javizqh merged 2 commits into from
May 20, 2025
Merged

Fixing docker crash changing world in harmonic #205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
286e5bd
fixed issue
dduro2020 Apr 24, 2025
92012ba
Cleaning in every 'terminate' state
dduro2020 May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion manager/manager/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ def on_launch_world(self, event):
Note:
The method logs the start of the launch transition and the configuration details for debugging and traceability.
"""

cfg_dict = event.kwargs.get("data", {})
world_cfg = cfg_dict['world']
robot_cfg = cfg_dict['robot']
Expand Down Expand Up @@ -722,15 +721,18 @@ def on_terminate_application(self, event):
except Exception:
LogManager.logger.exception("No application running")
print(traceback.format_exc())
self.terminate_harmonic_processes()

def on_terminate_visualization(self, event):

self.visualization_launcher.terminate()
if self.gui_server != None:
self.gui_server.stop()
self.gui_server = None
self.terminate_harmonic_processes()

def on_terminate_universe(self, event):

if self.world_launcher != None:
self.world_launcher.terminate()
if self.robot_launcher != None:
Expand Down