Windows Hypervisor support #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFoxRox
commented
Apr 18, 2018
| static void nopSignalHandler() { | ||
| // We don't actually need to do anything here, but we need to interrupt | ||
| // the execution of the guest. | ||
| } |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API should land in Windows 10 soon. The benefit over HAXM will be the support of non-intel CPUs (in the future.. hopefully).
I'm still open to the idea of adding HAXM for older versions of Windows (namely 7 and 8) in the future.
While this would only work on intel, it would still reach a number of users:
For macOS, which has a slightly different HAXM interface, we should instead use the Apple API in the future. There is no benefit in having HAXM on macOS as both, HAXM and the Apple API are only available starting with 10.10, but HAXM only works on intel, and will likely to continue to do so in the future (which could cause issues in the future). HAXM is also not allowed when shipping via the app-store.
FIXME: