OpenAL-soft 1.0.38 #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFoxRox
added
experiments
JayFoxRox
commented
Apr 15, 2020
| for(i = 0; i < BUFFER_COUNT; i++) { | ||
| buffers[i] = MmAllocateContiguousMemory(BUFFER_SIZE); | ||
| memset(buffers[i], 0x00, BUFFER_SIZE); | ||
| XAudioProvideSamples(buffers[i], BUFFER_SIZE, 0); |
JayFoxRox
commented
Apr 15, 2020
| }; | ||
|
|
||
|
|
||
| // This is injected instead of XAudio, so we don't have to modify the OpenAL submodule |
There was a problem hiding this comment.
Should be "registered as DSound"
|
This was accidentally 1.6.372 despite claiming to be 1.0.38. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of #72. This one is the first OpenAL port that I actually got working.
The backend pretends to be dsound. This was done so that the source-code of OpenAL-soft would not have to be touched at all.
I chose to implement xaudio as audio backend as I was worried that SDL Audio is crashy (we still don't know why that is).
Another reason for xaudio (over SDL Audio) was that I wanted to avoid useless copies or even mixing twice (once in OpenAL-soft, and then again in SDL Audio).
There are some obvious issues with xaudio though; namely that it can't be used co-operatively with SDL audio (although I'm not sure if people really use different APIs and OpenAL together).
The audio file for the sample also has to be copied from the xaudio sample.
Upgrading to a more recent OpenAL-soft submodule would be nice. But it might be difficult, so I'm keeping this as a stable prototype.
There are still many code quality issues and missing features which are stubbed by hacks. I'm not sure when I'll find the time for that. I'd be happy if someone else took care of it.