Made Armor Set calculations run asynchronously #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'm a bit busy lately, but I will try to get to merging this as soon as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this just made the function that calculates armor sets run on another thread (it otherwise remains mostly unchanged).
I didn't want to restructure the code too much, but ArmorSetFeatureHelper.armorSetSlots should only be accessed when the mutex is held. It's a quick and dirty solution, but it seems to work and it's better than having your game freeze for an uncomfortable amount of time after clicking the armor set tab.
I've tested this in both vanilla and calamity and haven't had any crashes or issues with the latest commit. Please tell me if you run into any issues.