-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
call delegate '#getService()' when looking up single service #132
base: master
Are you sure you want to change the base?
Conversation
as classes implementing `ServiceProvider` may define their own custom behaviour, let the `ServiceProvider` instance itself fetch a single service by name instead of using an own standard strategy (using the first one returned by `#getServices(Class)`) this way it is prevented that a `ServiceProvider` must load all services of the class even if they are not generellay needed (including all side effects e.g. loading data from remote services)
2664c9a
to
dd4cc06
Compare
Are you a JCP member? Because we cannot accept PRs from non-members in the API, RI or TCK repositories. We just had a MR1, so it may be up to the next version, if you are able to join the JCP we'd be happy to accept the PR. |
Hey @keilw! Thanks for your response. Thank you for your time and service. |
We have to see, the general mechanism is not different from other JSRs but it needs to wait till a really new JSR anyway. |
Any updates on this @keilw ? |
No @theborakompanioni there is no new JSR so it'll have to wait. |
as classes implementing
ServiceProvider
may define their own custom behaviour, let theServiceProvider
instance itself fetch a single service by name instead of using an own standard strategy (using the first one returned by#getServices(Class)
)this way it is prevented that a
ServiceProvider
must load all services of the class even if they are not generellay needed (including all side effects e.g. loading data from remote services)This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)