Repository navigation
GH-5209 follow-up: the dead letter history table has no schema drift - #5212
Merged
Merged
Conversation
Pins wolverine_dead_letter_history against Weasel reporting a difference on every startup, on PostgreSQL and SQL Server, next to the existing dead letter index checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCggXgxnG3EBXoR9rrq37U
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5210 (GH-5209). Test-only.
Adds
the_dead_letter_history_table_is_stabletoDeadLetterTable_index_creationin PostgresqlTests and SqlServerTests. It createswolverine_dead_letter_historyand asserts that Weasel then reportsSchemaPatchDifference.None. Weasel would otherwise re-apply DDL on every startup. That would cost time in every test host, so it was ruled out while looking at a slower CIPersistence run on #5210.Run locally:
PostgresqlTests --filter-class *.DeadLetterTable_index_creation3/3, andSqlServerTests --filter-class *.DeadLetterTable_index_creation3/3.🤖 Generated with Claude Code
https://claude.ai/code/session_01DCggXgxnG3EBXoR9rrq37U