fix(mqtt): wait for broker ack before completing durable sends - #3745
Merged
Conversation
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that MQTT transport does not persist outgoing messages in sqlite's
wolverine_outgoing_envelopes- something that potentially means message loss when using batching and the producer process is crashing.MqttTopic's sender used EnqueueAsync, which queues locally and returns
before the broker acknowledges the publish. For endpoints configured with
UseDurableOutbox()/UseDurableInbox(), this let the outbox entry be deleted
before delivery was actually confirmed, silently losing messages if the
broker was unreachable or the process crashed in between.
Now, MQTT sends through a new MqttSenderProtocol that
blocks on PublishAsync until the broker acks, matching how every other
transport with real broker acknowledgements works. Inline mode keeps its
existing fire-and-forget behavior unchanged.