Remove the stale RabbitMQ first-round-failures handoff (GH-3726) - #3731
Merged
Conversation
The handoff landed in #3727 to carry evidence between sessions, and that work is done. Leaving it at the repo root now actively misleads: * its headline item — the exclusive-listener failover test — is fixed in #3728, and its central claim that the listener "kept flapping" was wrong. The failover always worked; only the agent's reported status was stuck. * its Bug_1594 section describes a deterministic failure that does not exist. That test uses Servers.SqlServerConnectionString, and the three failing modes were a missing SQL Server container, not a product defect. GH-3726 carries the corrected account of all four tests, and the two still-unexplained ones stay tracked there and on #3729. Nothing is lost by deleting the file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handoff doc landed in #3727 to carry evidence between sessions. That work is done, and leaving the file at the repo root now actively misleads a reader:
multi_node_exclusive_listener_failover.listener_fails_over_when_the_leader_running_it_crashes— is fixed in Reset listener agent status to Running on restart (GH-3604) #3728. Its central claim, that the listener "kept flapping," was wrong: the failover always worked and only the agent's reported status was stuck. The doc tells the next reader to go chase a flap that does not exist.Servers.SqlServerConnectionString, and the three failing modes were a missing SQL Server container, not a product defect.#3726 carries the corrected account of all four tests, and the two that are still unexplained stay tracked there and on #3729. Nothing is lost by deleting the file.
🤖 Generated with Claude Code