GH-3365: stop double-registering the primary Polecat IEventStore

[jeremydmiller]

Root cause (not the one suspected in the issue)

The issue guessed that WolverineOptionsPolecatExtensions.IntegrateWithWolverine() was executing twice — once explicitly, once from an internal integration pass. That is wrong. IntegrateWithWolverine() runs exactly once.

The duplicate comes from Polecat itself. Dumping the IServiceCollection for the reported host shape produces three IEventStore descriptors with these implementation factories:

IEventStore -> Polecat.PolecatServiceCollectionExtensions+<>c.<AddPolecat>b__3_4                    <-- Polecat's own
IEventStore -> Wolverine.Polecat.WolverineOptionsPolecatExtensions+<>c.<IntegrateWithWolverine>b__0_3  <-- ours, redundant
IEventStore -> Wolverine.Polecat.AncillaryWolverineOptionsPolecatExtensions+<>c__0`1[ICritterWatchStore]...

AddPolecat() now registers the store-agnostic JasperFx.Events.IEventStore for the primary DocumentStore on its own — verified against all four AddPolecat overloads (Action<StoreOptions>, string, StoreOptions, Func<IServiceProvider, StoreOptions>) at Polecat 4.8.0, the floor of our package range. Both factories resolve the same IDocumentStore singleton, hence the reference-equal duplicate.

Wolverine's bridge dates to GH-3133 / GH-3219, when AddPolecat genuinely did not register IEventStore. Once Polecat started doing so, the two stacked.

Fix

Delete the redundant primary bridge in WolverineOptionsPolecatExtensions.IntegrateWithWolverine(). This restores parity with Wolverine.Marten, which registers nothing equivalent for its primary store precisely because AddMarten handles it.

TryAddEnumerable is not usable here: it throws when the descriptor's implementation type equals its service type, which is the case for an AddSingleton<IEventStore>(sp => ...) factory registration on both sides.

The ancillary bridge in AncillaryWolverineOptionsPolecatExtensions is untouched and still required — AddPolecatStore<T>() does not register IEventStore for the T store.

Test

New does_not_register_any_event_store_twice in bootstrapping_ancillary_polecat_stores_with_wolverine (primary + ancillary host shape from the issue) asserts reference-distinctness, not just a count: every resolved store is a distinct instance, the primary appears exactly once, each ancillary exactly once. It fails loudly if Polecat ever drops its own registration.

• Full PolecatTests suite: 241 passed, 4 skipped, 0 failed
• dotnet build wolverine.slnx -c Release: clean, 0 warnings

Fixes #3365

🤖 Generated with Claude Code