Retrofit MessageStoreRole registration tests to all relational providers (#3351 follow-up) - #3354
Merged
Merged
Conversation
…Sql, and Oracle (#3351 follow-up) PR #3351 fixed the same tenanted-store Role defect in all five relational providers but only added regression tests for PostgreSQL. This adds the equivalent three-case test (ancillary single-database, ancillary with static tenants, Main default with static tenants) to the other four providers' test suites. All are configuration-only tests that never touch a database. Mutation-checked on SqlServer: reverting the Role propagation in buildMainDatabaseSettings fails both ancillary tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #3351, which fixed the
MessageStoreRole-ignored-on-tenanted-paths defect in all five relational providers (PostgreSQL, Sql Server, Sqlite, MySql, Oracle) but only added regression tests for PostgreSQL.This retrofits the same three-case test to the other four providers:
SqlServerTests/message_store_role_registration.csSqliteTests/message_store_role_registration.csMySqlTests/message_store_role_registration.csOracleTests/message_store_role_registration.csEach covers: ancillary single-database, ancillary with statically registered tenants, and the
Maindefault with statically registered tenants. All are pure configuration tests overBuildMessageStore()— no database connection is opened, so they run without docker infrastructure. The SQLite variant uses throwaway file-based connection strings via the existingSqliteTests.Servershelper because SQLite persistence rejects non-file connection strings.Verification
All 12 new tests pass locally. Mutation-checked on Sql Server: reverting the
Rolepropagation inbuildMainDatabaseSettings()fails both ancillary tests and leaves the Main-default test green — same kill pattern as the original PostgreSQL tests.🤖 Generated with Claude Code