fix(shared-memory): copy envelopes at transport handoff#3333
Merged
jeremydmiller merged 1 commit intoJul 8, 2026
Merged
Conversation
Member
|
@Steve-XYZ Thanks for taking that on! Frankly, that was probably never something I was going to get around to |
This was referenced Jul 9, 2026
Merged
This was referenced Jul 15, 2026
Open
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3015 by giving Shared Memory receivers a new
Envelopeinstance at the transport handoff boundary instead of retaining the sender's pooled envelope.This follows the intended ownership model: the sender may recycle its pooled envelope after
SendAsync()completes, while each asynchronous receiver owns an independent envelope wrapper.Changes
Validation
The combined Shared Memory compliance selection has pre-existing cross-test interference in
can_send_from_one_node_to_another_by_publishing_rule; both inline and buffered cases pass in isolation.