Durable HTTP transport never deletes the outgoing envelope (#3173)#3209
Merged
Conversation
HttpSenderProtocol.SendBatchAsync sent the batch but never invoked the ISenderCallback, so the DurableSendingAgent never deleted the outgoing envelopes from the outbox — a successfully delivered message redelivered forever and the Outgoing count never dropped. Mirror the other transport sender protocols (Redis/Kafka): call MarkSuccessfulAsync(batch) on success and MarkProcessingFailureAsync(batch, ex) on failure. Also make the transport client EnsureSuccessStatusCode() so a non-2xx response is treated as a failure (requeue) rather than silently acknowledged. Adds regression coverage to HttpSenderTests for both the success-ack and failure-requeue paths. Closes #3173 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 23, 2026
Closed
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the durable HTTP transport redelivering successfully-processed messages forever (the
Outgoingoutbox count never drops).Root cause
HttpSenderProtocol.SendBatchAsyncposted the batch but never invoked theISenderCallback:Every other transport's
ISenderProtocol(Redis, Kafka, …) callscallback.MarkSuccessfulAsync(batch)on success /callback.MarkProcessingFailureAsync(batch, ex)on failure. That callback is what drivesDurableSendingAgent.MarkSuccessfulAsync→DeleteOutgoingAsync, removing the outbox row. Without it, the outgoing envelope is never deleted and the durable sending agent re-sends it indefinitely.Fix
HttpSenderProtocol.SendBatchAsyncnowMarkSuccessfulAsyncon success andMarkProcessingFailureAsyncon exception.WolverineHttpTransportClient.SendBatchAsync(and the CloudEvents client) nowEnsureSuccessStatusCode(), so a non-2xx response throws → is treated as a failure (requeue) rather than silently acknowledged and deleted.HttpSenderTests: a successful batch acks (MarkSuccessfulAsync), a throwing client reports failure (MarkProcessingFailureAsync) and never acks.Closes #3173
🤖 Generated with Claude Code