Cover keyed constructor injection under Lamar too (#3081)#3087
Merged
Conversation
Follow-up to #3086. The #3081 fix (JasperFx 2.9.10) lives in the shared codegen layer, so it applies to any container — but the issue was reported on Lamar, so add an explicit Lamar variant of the keyed-constructor-injection test. - Add Lamar.Microsoft.DependencyInjection to CoreTests (its transitive JasperFx unifies up to Wolverine's 2.9.10 — no version conflict). - keyed_services_on_handler_constructor now runs the same scenario against both the default container and Host.CreateDefaultBuilder().UseLamar(), sharing one helper, asserting each [FromKeyedServices] constructor parameter resolves to its own registration. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 15, 2026
This was referenced Jun 23, 2026
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3086 (which closed #3081). That PR added a keyed-constructor-injection regression test against the default container. Since #3081 was reported on Lamar, this adds an explicit Lamar variant so the scenario is covered on both containers.
The JasperFx 2.9.10 fix is in the shared codegen layer (
ConstructorFrame), so it's container-agnostic — but having a Lamar test guards the LamarServiceVariableSourcekeyed-resolution path explicitly.Changes
Lamar.Microsoft.DependencyInjection16.0.0 toCoreTests. Its transitive JasperFx unifies up to Wolverine's 2.9.10 — no version conflict / no downgrade.keyed_services_on_handler_constructornow runs the same scenario (two[FromKeyedServices]constructor params of the same service type,"Test"→FirstRepo,"Test2"→SecondRepo) against both the default container andHost.CreateDefaultBuilder().UseLamar(), via one shared helper.Verification
UseLamar()).wolverine.slnx -c Releasebuilds clean — 0 warnings, 0 errors.🤖 Generated with Claude Code