Promote Mode + IsListener to typed EndpointDescriptor fields; drop redundant Http Sets.Routes (#3009)#3010
Merged
Conversation
…dundant Http Sets.Routes (GH-3009) Two payload-shrink changes for the ServiceCapabilities snapshot: 1. EndpointDescriptor now exposes Mode and IsListener as first-class typed fields (alongside BrokerRole/EndpointRole/etc.), lifted from the underlying Endpoint. The duplicate generic OptionsDescription rows the base ctor reflects off the Endpoint are removed so they aren't shipped twice — CritterWatch reads these at the service-overview level, and Properties is becoming lazy-fetchable downstream. 2. HttpCapabilityDescriptor no longer emits the per-route "Routes" child set (~96 KB on a Topicus-scale graph). It was fully redundant with HttpGraphs[*].Chains, which the SPA already reads; the Sets collection on this capability had no other consumer. Regression tests: CoreTests endpoint_descriptor_mode_tests (typed fields populated + no duplicate Properties rows) and Http http_capability_descriptor_tests (no "Routes" set, core capability content intact). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3009.
Two payload-shrink changes on the
ServiceCapabilitiessnapshot, building on the HTTP descriptor cleanup in #411 / #3008.1.
Mode+IsListener→ typed fields onEndpointDescriptorToday these ride along as generic
OptionsDescriptionrows underEndpointDescriptor.Properties. CritterWatch consumes both at the service-overview level, so they can't simply ride along oncePropertiesbecomes lazy-fetchable downstream.Mode(EndpointMode) andIsListener(bool) as first-class typed properties, lifted from the underlyingEndpoint— same shape as the existingBrokerRole/EndpointRole/TransportType/SerializerTypefields.Mode/IsListenerrows from thePropertiesenumeration (the baseOptionsDescriptionctor reflects them off theEndpoint) so we don't double-ship.2. Drop
Sets.Routesfrom theWolverine.HttpcapabilityHttpCapabilityDescriptorno longer emits the per-routeRouteschild set (~96 KB on a Topicus-scale graph). It was fully redundant withHttpGraphs[*].Chains, which the SPA already reads; theSetscollection on this capability has no other consumer. The remainingProperties/Tagson the entry are tiny and unaffected.Tests
endpoint_descriptor_mode_tests— typed fields populated from the endpoint (Durable/listener andBufferedInMemory/non-listener), and no duplicateMode/IsListenerrows left inProperties.http_capability_descriptor_tests— against the real WolverineWebApi host (which has routes, so the oldRoutesset would have been populated): asserts noRoutesset, with the core capability content (httptag,WarmUpRoutes) intact.Full
wolverine.slnxRelease build clean (0 warnings / 0 errors); adjacent descriptor/capability suite (61 tests) green.Payload impact
Sets.Routesdrop: ~96 KB raw.Mode/IsListenerunblocks the CritterWatch follow-up that makesMessagingEndpoints[].Properties/Childrenlazy-fetchable: ~570 KB raw.🤖 Generated with Claude Code