Bump JasperFx to 2.2.5; adopt built-in Variable.FSharpUsage (GH-2969)#2979
Merged
Conversation
JasperFx 2.2.5 (#395) adds a built-in F#-aware Variable.FSharpUsage that renders CastVariable as an F# :>/:?> cast. Adopt it and retire Wolverine's local workaround. - Bump JasperFx / .Events / .Events.SourceGenerator / .SourceGenerator 2.2.4 -> 2.2.5 (RuntimeCompiler stays on its 5.x line). - Replace the four FSharpEmitHelpers.FSharpUsage(x) call sites (RequirementResult/SimpleValidation logger, SetSagaIdFrame sagaId, AuditToActivityFrame input) with the built-in x.FSharpUsage property. - Remove FSharpEmitHelpers.FSharpUsage (keep WriteAbortGuard). Behaviour-preserving: the regenerated fixtures are byte-identical (the logger still renders as `(_loggerForMessage :> ILogger)`). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dmytro-pryvedeniuk
pushed a commit
to dmytro-pryvedeniuk/wolverine
that referenced
this pull request
May 30, 2026
Extends ReadHttpFrame's F# emit to parsed (non-string) binding for a method
argument, building on the string binding.
- writeParsedValueFSharp: F# auto-tuples the C# out-parameter TryParse into a
`match Type.TryParse(raw, InvariantCulture) with | true, v -> ... | _ -> ...`.
- Route value: null or parse-failure 404s + aborts; success binds the variable
and renders the rest of the chain in the success arm (no F# early return).
- Query/form/header: binds the parsed value or Unchecked.defaultof<T> on
failure, then continues.
- Nullable/optional and enum parsed binding still throw NotSupported (deferred).
- Fixture: GET /things/{id}/items/{count} (string + int route values) and
GET /paged?page= (int query) render + compile.
NOTE: this branch also carries the route/query *string* binding commit (PR JasperFx#2980)
that merged into the stacked JasperFx#2979 branch and never reached main; re-landing it
here.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 1, 2026
Merged
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JasperFx 2.2.5 (jasperfx#395) adds a built-in F#-aware
Variable.FSharpUsagethat renders aCastVariableas an F#:>/:?>cast. This adopts it and retires Wolverine's local workaround.Changes
JasperFx/.Events/.Events.SourceGenerator/.SourceGenerator2.2.4 → 2.2.5 (RuntimeCompiler stays on its 5.x line).FSharpEmitHelpers.FSharpUsage(x)call sites (RequirementResult/SimpleValidation logger,SetSagaIdFramesagaId,AuditToActivityFrameinput) with the built-inx.FSharpUsageproperty.FSharpEmitHelpers.FSharpUsage(keepWriteAbortGuard).Verification
(_loggerForMessage :> ILogger)), so the diff is purely the pin + call-site swap.fsharp-coverageunchanged (Core 25/2/17, HTTP-loaded 28/2/51).dotnet build wolverine.slnx -c Releaseregression on 2.2.5 — 0 warnings, 0 errors.Part of #2969.
🤖 Generated with Claude Code