Correct analysis#2961
Merged
jeremydmiller merged 7 commits intoMay 31, 2026
Merged
Conversation
dmytro-pryvedeniuk
force-pushed
the
correct-analysis
branch
from
0392e4b to
c060739
Compare
Member
|
@dmytro-pryvedeniuk Hey man, I appreciate all this kind of thing, but if the analysis stuff causes friction, I will rip it out later |
dmytro-pryvedeniuk
force-pushed
the
correct-analysis
branch
from
c060739 to
2f8b214
Compare
Contributor
Author
|
@jeremydmiller I don't add new analyzers, just let the existing ones to analyze all projects. Consistency matters. If with "friction" you mean false positives it's inevitable with any code analysis I am afraid. |
dmytro-pryvedeniuk
force-pushed
the
correct-analysis
branch
from
2f8b214 to
6251de4
Compare
Member
|
"Consistency matters." -- some things matter, other things are noise and friction. I'll try it for awhile. |
This was referenced Jun 1, 2026
This was referenced Jun 3, 2026
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues with code analysis
Microsoft.CodeAnalysis.NetAnalyzersis used with condition having a typo that resolves tofalse. It means that SDK version is used instead. This reference is removed to avoid confusion.Analysis.Build.propsAnalysisModeReliabilityis set totrue. It's not a valid value, valid ones are listed here - https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#analysismode. Invalid value is ignored. Removed to avoid confusion.Analysis.Build.propsis not referenced by all projects. Only some of them reference it directly in csproj. It means for many projects warnings are skipped. - Imported Analysis.Build.props in Directory.Build.prop.