fix(build): include Wolverine.HealthChecks in the Pack target#2712
Merged
jeremydmiller merged 1 commit intomainfrom May 8, 2026
Merged
fix(build): include Wolverine.HealthChecks in the Pack target#2712jeremydmiller merged 1 commit intomainfrom
jeremydmiller merged 1 commit intomainfrom
Conversation
Closes #2704. The release workflow (`.github/workflows/publish_nugets.yml`) runs `./build.sh pack` and then `find . -name '*.nupkg' -exec dotnet nuget push`. The `Pack` target in `build/build.cs` packs each project named in a hardcoded `nugetProjects` array — and `Wolverine.HealthChecks` was never added to it. The project is in `wolverine.slnx`, builds cleanly, has a `<PackageId>WolverineFx.HealthChecks</PackageId>` metadata block, and has tests, but no `.nupkg` is ever produced during a release run, so nothing reaches nuget.org. One-line addition: `Solution.Wolverine_HealthChecks` slotted next to `Solution.Wolverine` in the array. Verified locally with `dotnet pack src/Wolverine.HealthChecks/Wolverine.HealthChecks.csproj --configuration Release` — produces `WolverineFx.HealthChecks.5.38.0.nupkg` without errors.
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2704.
Diagnosis
The release workflow (
.github/workflows/publish_nugets.yml) runs./build.sh packand then afind . -name '*.nupkg' -exec dotnet nuget pushover the artifacts. ThePacktarget inbuild/build.csonly packs the projects named in a hardcodednugetProjectsarray.Wolverine.HealthCheckswas never added to that array. The project is inwolverine.slnx, references core via<ProjectReference>, has the right<PackageId>WolverineFx.HealthChecks</PackageId>metadata, and has tests — butdotnet packis never invoked on it during a release, so no.nupkgis produced and nothing reaches nuget.org. The reporter randotnet add package WolverineFx.HealthChecksand got "no versions available" because no version has ever been pushed, even though every other piece of the pipeline (project, docs page, tests) has been in place since the package was introduced.Fix
One line: slot
Solution.Wolverine_HealthChecksinto thePacktarget'snugetProjectsarray next toSolution.Wolverine(parallel naming since both.csprojs sit at the top level ofsrc/).Verification
$ dotnet pack src/Wolverine.HealthChecks/Wolverine.HealthChecks.csproj \ --configuration Release --output /tmp/check $ ls /tmp/check WolverineFx.HealthChecks.5.38.0.nupkgThe build script itself (
build/build.csproj) compiles cleanly with the newSolution.Wolverine_HealthChecksaccessor — Nuke's solution-property generator picks it up from the existing<Project Path="src/Wolverine.HealthChecks/Wolverine.HealthChecks.csproj" />entry inwolverine.slnx.The next manual run of the Publish Wolverine Nugets workflow will produce and push
WolverineFx.HealthChecks.<version>.nupkg.