chore(core): remove Wolverine-specific Roslyn source generator#2679
Merged
jeremydmiller merged 1 commit intomainfrom May 5, 2026
Merged
chore(core): remove Wolverine-specific Roslyn source generator#2679jeremydmiller merged 1 commit intomainfrom
jeremydmiller merged 1 commit intomainfrom
Conversation
Strips the experimental Wolverine.SourceGeneration analyzer project and its IWolverineTypeLoader / [WolverineTypeManifest] / CompositeWolverineTypeLoader surface. The compile-time handler-discovery branch was never exercised in steady state — handler graph compilation always falls back to compileWithRuntimeScanning, so the source-gen path was carrying weight without pulling any. Removes: - src/Wolverine.SourceGeneration/ (whole project) - IWolverineTypeLoader, CompositeWolverineTypeLoader, WolverineTypeManifestAttribute - The analyzer ProjectReference + Pack include in Wolverine.csproj - The source-gen branches in ExtensionLoader.ApplyExtensions, WolverineRuntime.HostService startup, HandlerGraph.Compile, and HandlerChain.AttachTypes - TypeLoaderManifestModuleA/B test fixtures and their aggregation tests JasperFx.SourceGeneration (separate package, used as analyzer reference) is unaffected. Bumps to 5.37.2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wolverine.SourceGenerationanalyzer project and itsIWolverineTypeLoader/[WolverineTypeManifest]/CompositeWolverineTypeLoadersurface — the compile-time handler-discovery branch was never wired up in steady state, so the source-gen path was carrying weight without pulling any. Handler graph compilation always falls back tocompileWithRuntimeScanning, which has been the only exercised path.Wolverine.csproj(so the WolverineFx NuGet no longer ships the netstandard2.0 analyzer DLL), removes the source-gen branches inExtensionLoader.ApplyExtensions,WolverineRuntime.HostServicestartup,HandlerGraph.Compile, andHandlerChain.AttachTypes, plus the twoTypeLoaderManifestModule*test fixtures and their aggregation tests.JasperFx.SourceGeneration(separate package, used as analyzer reference) is unaffected. Bumps to 5.37.2.Test plan
dotnet build src/Wolverine/Wolverine.csproj --framework net9.0cleandotnet test src/Testing/CoreTests/CoreTests.csproj --framework net9.0— 1537 passed, 0 failed🤖 Generated with Claude Code