Skip to content

Fixing a regression problem with explicit type discovery getting lost… #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
May 5, 2026
+5 −3
Merged

Fixing a regression problem with explicit type discovery getting lost… #2678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<NoWarn>1570;1571;1572;1573;1574;1587;1591;1701;1702;1711;1735;0618;VSTHRD200</NoWarn>
<ImplicitUsings>true</ImplicitUsings>
<Nullable>enable</Nullable>
<Version>5.37.0</Version>
<Version>5.37.1</Version>
<RepositoryUrl>$(PackageProjectUrl)</RepositoryUrl>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
Expand Down
4 changes: 3 additions & 1 deletion src/Wolverine/Configuration/HandlerDiscovery.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,9 @@ internal IEnumerable<Type> findAllMessages(HandlerGraph handlers)
.Distinct()
.SelectMany(actionsFromType).ToArray();
}


internal IList<Type> ExplicitTypes => _explicitTypes;

/// <summary>
/// Discovers and includes all assemblies marked with [WolverineHandlerModule] attribute.
/// </summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Wolverine/Runtime/Handlers/HandlerGraph.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ private void compileWithTypeLoader(WolverineOptions options, ILogger logger)
logger.LogInformation(
"Using source-generated type loader for handler discovery, bypassing runtime assembly scanning");

var handlerTypes = _typeLoader!.DiscoveredHandlerTypes;
var handlerTypes = _typeLoader!.DiscoveredHandlerTypes.Concat(Discovery.ExplicitTypes);

// Still use Discovery's method filtering on the pre-discovered types,
// but skip the expensive assembly scanning to find those types
Expand Down
Loading