Skip to content

Outbox behavior alignment with EF Core transaction model #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 4 commits into from
May 8, 2026
+10 −14
Merged

Outbox behavior alignment with EF Core transaction model #2677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a0a377
Outbox behavior alignment with EF Core transaction model
Ferchke7 May 5, 2026
b8c72b9
Fixes the test
Ferchke7 May 5, 2026
03fe57b
End to end ef core
Ferchke7 May 5, 2026
2dd39ff
Changes
Ferchke7 May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Persistence/EfCoreTests/eager_idempotency_with_non_wolverine_mapped_db_context.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,4 +145,4 @@ public async Task sad_path_eager_idempotency()


}
}
}
22 changes: 9 additions & 13 deletions src/Persistence/Wolverine.EntityFrameworkCore/Internals/EfCoreEnvelopeTransaction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,16 @@ public EfCoreEnvelopeTransaction(DbContext dbContext, MessageContext messaging)

public async Task PersistOutgoingAsync(Envelope envelope)
{
if (DbContext.Database.CurrentTransaction == null)
{
await DbContext.Database.BeginTransactionAsync();
}

if (DbContext.IsWolverineEnabled())
{
DbContext.Add(new OutgoingMessage(envelope));
}
else
{
if (DbContext.Database.CurrentTransaction == null)
{
await DbContext.Database.BeginTransactionAsync();
}
var conn = DbContext.Database.GetDbConnection();
var tx = DbContext.Database.CurrentTransaction!.GetDbTransaction();
var cmd = DatabasePersistence.BuildOutgoingStorageCommand(envelope, envelope.OwnerId, _database);
Expand All @@ -61,8 +60,6 @@ public async Task PersistOutgoingAsync(Envelope envelope)

await cmd.ExecuteNonQueryAsync();
}


}

public async Task PersistOutgoingAsync(Envelope[] envelopes)
Expand All @@ -72,17 +69,16 @@ public async Task PersistOutgoingAsync(Envelope[] envelopes)
return;
}

if (DbContext.Database.CurrentTransaction == null)
{
await DbContext.Database.BeginTransactionAsync();
}

if (DbContext.IsWolverineEnabled())
{
DbContext.AddRange(envelopes.Select(e => new OutgoingMessage(e)));
}
else
{
if (DbContext.Database.CurrentTransaction == null)
{
await DbContext.Database.BeginTransactionAsync();
}
var conn = DbContext.Database.GetDbConnection();
var tx = DbContext.Database.CurrentTransaction!.GetDbTransaction();
var cmd = DatabasePersistence.BuildOutgoingStorageCommand(envelopes, envelopes[0].OwnerId, _database);
Expand Down Expand Up @@ -176,7 +172,7 @@ public async ValueTask CommitAsync(CancellationToken cancellation)
if (_messaging.Envelope != null && _messaging.Envelope.Destination != null)
{
var conn = DbContext.Database.GetDbConnection();
var tx = DbContext.Database.CurrentTransaction!.GetDbTransaction();
var tx = DbContext.Database.CurrentTransaction?.GetDbTransaction();

// Are we marking an existing envelope as persisted?
if (_messaging.Envelope.WasPersistedInInbox)
Expand Down
Loading