Fix CI failures from PR #2511#2515
Merged
jeremydmiller merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
- Convert soft_deleted_saga_experiment from throwing exceptions to report findings into proper assertion-based tests documenting known behavior (sagas are resurrected when sent messages after soft-delete) - Add sqlserver to MQTT CI docker services since the new mapper exception dead-letter test requires SQL Server persistence Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix saga_is_soft_deleted_when_completed: Marten's LoadAsync() does NOT filter soft-deleted documents (only LINQ queries do), so the assertion expecting null was wrong. Updated to assert correct Marten behavior. - Mark AWS when_using_handler_type_naming as Flaky, consistent with all other ConventionalRouting tests in the SQS test suite. - Correct saga docs: Wolverine uses session.Delete() (not hard-delete), which respects Marten soft-delete configuration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
soft_deleted_saga_experimenttests were deliberately throwing exceptions to report experimental findings. Converted them to proper assertion-based tests that document the known behavior (soft-deleted sagas are resurrected when sent messages viaLoadAsync).Bug_mapper_exception_routes_to_dlqtest from PR Fix silent message loss when envelope mapper throws (RabbitMQ + MQTT) #2511 usesPersistMessagesWithSqlServer, but theCIMQTTNuke target only started PostgreSQL. Addedsqlserverto the MQTT docker services.Test plan
🤖 Generated with Claude Code