Fix EfCoreEnvelopeTransaction batch outgoing envelopes using wrong storage command#2479
Merged
jeremydmiller merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
… batch outgoing envelopes PersistOutgoingAsync(Envelope[]) was incorrectly calling DatabasePersistence.BuildIncomingStorageCommand for the non-Wolverine-enabled DbContext path, causing outgoing envelopes to be inserted with incoming schema fields instead of outgoing ones. Fixes #2474. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EfCoreEnvelopeTransaction.PersistOutgoingAsync(Envelope[])where the non-Wolverine-enabledDbContextpath was callingDatabasePersistence.BuildIncomingStorageCommandinstead ofBuildOutgoingStorageCommandPersistOutgoingAsync(Envelope)overload was already correct; only the array overload was affectedDbContextCloses #2474
Test plan
persist_batch_outgoing_envelopes_uses_outgoing_tableineager_idempotency_with_non_wolverine_mapped_db_contextverifies envelopes appear inAllOutgoingAsync()and notAllIncomingAsync()after the fixdocker compose up -d)🤖 Generated with Claude Code