Copy Envelope.Headers to MassTransitEnvelope on write path#2439
Merged
jeremydmiller merged 1 commit intoJasperFx:mainfrom Apr 6, 2026
Merged
Conversation
…structor Headers were only transferred from MassTransit to Wolverine (via TransferData), but not the other way. Copy envelope headers in the constructor so they get serialized outbound. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
@outofrange-consulting Huh, big miss, glad you filled that in. This will be in the next Wolverine coming up soon |
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MassTransitEnvelope<T>constructor transfers message ID, correlation ID, conversation ID, and expiration time from a WolverineEnvelope, but not custom headers.TransferData()already handles the reverse direction (MassTransit → Wolverine), so header mapping was one-way only.@jeremydmiller — This change copies all
Envelope.Headersinto the outbound MassTransit envelope. This could potentially include headers that are Wolverine-internal and not intended for external consumers. Only E2E / integration tests with actual MassTransit consumers can confirm whether any unwanted headers leak through. Would appreciate your review to validate this is safe.Test plan
create_masstransit_envelope_from_envelopetest to verify headers are copiedMassTransitEnvelopeTestspass🤖 Generated with Claude Code